Skip to content

[CMake] Use CMake's find_package module to detect git #817

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[CMake] Use CMake's find_package module to detect git #817

wants to merge 1 commit into from

Conversation

diizzyy
Copy link

@diizzyy diizzyy commented Mar 2, 2025

Instead of enforcing execution of git if available use CMake's find_package module to make it optional.

@diizzyy
[CMake] Use CMake's find_package module to detect git
22ad63f 
Instead of enforcing execution of git if available use CMake's find_package module to make it optional.
@diizzyy
Copy link
Author

diizzyy commented Mar 2, 2025

Counterpart to what's being available using Autotools, https://github.com/xiph/flac/blob/master/configure.ac#L369

@dg0yt
Copy link
Contributor

dg0yt commented Apr 17, 2025

IMO this should be complemented by replacing the use of literal git wiht "${GIT_EXECUTABLE}". User may seed this cache variable without even having git in PATH.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@diizzyy @dg0yt